linux-kernel - RE: [PATCH v1 2/3] usb: phy: Add driver for the Realtek SoC USB 2.0/3.0 PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ee8a26205a041cab9a787ec29201a9f@realtek.com>
Date:   Fri, 19 May 2023 10:58:54 +0000
From:   Stanley Chang[昌育德] 
        <stanley_chang@...ltek.com>
To:     Paul Cercueil <paul@...pouillou.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Vinod Koul <vkoul@...nel.org>,
        Kishon Vijay Abraham I <kishon@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Alan Stern <stern@...land.harvard.edu>,
        Ray Chi <raychi@...gle.com>,
        "Bagas Sanjaya" <bagasdotme@...il.com>,
        Eugeniu Rosca <erosca@...adit-jv.com>,
        Michael Grzeschik <m.grzeschik@...gutronix.de>,
        Matthias Kaehlcke <mka@...omium.org>,
        Flavio Suligoi <f.suligoi@...m.it>,
        Mathias Nyman <mathias.nyman@...ux.intel.com>,
        Bhuvanesh Surachari <Bhuvanesh_Surachari@...tor.com>,
        Arnd Bergmann <arnd@...db.de>,
        "Linus Walleij" <linus.walleij@...aro.org>,
        "linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: RE: [PATCH v1 2/3] usb: phy: Add driver for the Realtek SoC USB 2.0/3.0 PHY

Hi Paul,

> > Realtek DHC (digital home center) RTD SoCs support DWC3 XHCI USB
> > 2.0/3.0
> > controller. Added two drivers to drive the  USB 2.0/3.0 PHY
> > transceivers.
> > For USB 3.0 transceivers, a driver phy-rtk-usb3 is provided.
> > The driver phy-rtk-usb2 is used to support USB 2.0 transceivers.
> >
> > Signed-off-by: Stanley Chang <stanley_chang@...ltek.com>
> > ---
> >  drivers/usb/phy/Kconfig        |   14 +
> >  drivers/usb/phy/Makefile       |    2 +
> >  drivers/usb/phy/phy-rtk-usb.h  |   88 ++
> >  drivers/usb/phy/phy-rtk-usb2.c | 2196
> > ++++++++++++++++++++++++++++++++
> >  drivers/usb/phy/phy-rtk-usb3.c | 1165 +++++++++++++++++
> >  5 files changed, 3465 insertions(+)
> >  create mode 100644 drivers/usb/phy/phy-rtk-usb.h
> >  create mode 100644 drivers/usb/phy/phy-rtk-usb2.c
> >  create mode 100644 drivers/usb/phy/phy-rtk-usb3.c
> 
> I'm pretty sure that drivers/usb/phy/ is deprecated now...
> 
> New drivers should be written for the generic PHY subsystem in
> drivers/phy/.
> 
Thanks for your reminder.
Will drivers/usb/phy be removed?
Is it not allowed to add new drivers?

In our application, driver/phy is not suitable.
We need to notify the phy driver when the USB hub port status changes.
However, generic PHY drivers are designed for various device's PHY.
And it seems inappropriate to add this function. So we choose to use driver/usb/phy. 

Thanks,
Stanley