linux-kernel - Re: [PATCH v1 2/3] usb: phy: Add driver for the Realtek SoC USB 2.0/3.0 PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <f7edea0c-dbfe-4c16-8134-0656411a837d@app.fastmail.com>
Date:   Fri, 19 May 2023 13:01:34 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Stanley Chang" <stanley_chang@...ltek.com>,
        "Paul Cercueil" <paul@...pouillou.net>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
Cc:     "Vinod Koul" <vkoul@...nel.org>,
        "Kishon Vijay Abraham I" <kishon@...nel.org>,
        "Rob Herring" <robh+dt@...nel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
        "Conor Dooley" <conor+dt@...nel.org>,
        "Alan Stern" <stern@...land.harvard.edu>,
        "Ray Chi" <raychi@...gle.com>,
        "Bagas Sanjaya" <bagasdotme@...il.com>,
        "Eugeniu Rosca" <erosca@...adit-jv.com>,
        "Michael Grzeschik" <m.grzeschik@...gutronix.de>,
        "Matthias Kaehlcke" <mka@...omium.org>,
        "Flavio Suligoi" <f.suligoi@...m.it>,
        "Mathias Nyman" <mathias.nyman@...ux.intel.com>,
        "Bhuvanesh Surachari" <Bhuvanesh_Surachari@...tor.com>,
        "Linus Walleij" <linus.walleij@...aro.org>,
        "linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: Re: [PATCH v1 2/3] usb: phy: Add driver for the Realtek SoC USB 2.0/3.0 PHY

On Fri, May 19, 2023, at 12:58, Stanley Chang[昌育德] wrote:
>> 
>> I'm pretty sure that drivers/usb/phy/ is deprecated now...
>> 
>> New drivers should be written for the generic PHY subsystem in
>> drivers/phy/.

Indeed, I missed that in my review.

> Thanks for your reminder.
> Will drivers/usb/phy be removed?
> Is it not allowed to add new drivers?
>
> In our application, driver/phy is not suitable.
> We need to notify the phy driver when the USB hub port status changes.
> However, generic PHY drivers are designed for various device's PHY.
> And it seems inappropriate to add this function. So we choose to use 
> driver/usb/phy. 

If you run into something that works in the old usbphy layer
but can't be done in drivers/phy, I think the better solution
would be to change the drivers/phy/ code to add this.

      Arnd