linux-kernel - Re: [PATCH v2 0/2] Add dt-binding support for ti tmp006

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 20 May 2023 23:32:03 +0100
From:   Conor Dooley <conor@...nel.org>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     Anup Sharma <anupnewsmail@...il.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Peter Meerwald <pmeerw@...erw.net>,
        u.kleine-koenig@...gutronix.de, andriy.shevchenko@...ux.intel.com,
        linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] Add dt-binding support for ti tmp006

On Sat, May 20, 2023 at 04:20:02PM +0100, Jonathan Cameron wrote:
> On Sat, 20 May 2023 16:21:50 +0530
> Anup Sharma <anupnewsmail@...il.com> wrote:
> 
> > These patches introduce device tree binding support and
> > add an of_device_id table entry to the driver.
> > 
> > Changes in v2:
> > 	- Keep the exsisting MODULE_DEVICE_TABLE entry.
> > 	- Removed the inner comma in of_device_id.
> > 	- Order the included header to improve code organization.
> > 	- Adding missing semicolon to fix syntax error detected
> > 	  using dt_binding_check.
> > 	
> LGTM - I'll leave them a little while though for others to comment before
> picking them up.

It may be a wee bit before you here from Krzysztof, but the binding
check issues have been fixed, as have the things he pointed out in the
original submission AFAICT.
Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

Thanks,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)