[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75VeR724n7C8hXs_7+TfvXANPZ7man3Znns8O+mBc113fYw@mail.gmail.com>
Date: Sun, 21 May 2023 11:59:50 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Boerge Struempfel <boerge.struempfel@...il.com>
Cc: bstruempfel@...ratronik.de, festevam@...il.com,
amit.kumar-mahapatra@....com, broonie@...nel.org,
Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
NXP Linux Team <linux-imx@....com>,
linux-spi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 4/4] spi: spidev_test Add three missing spi mode bits
On Sat, May 20, 2023 at 10:09 PM Boerge Struempfel
<boerge.struempfel@...il.com> wrote:
>
> Added the three missing spi mode bits SPI_3WIRE_HIZ, SPI_RX_CPHA_FLIP,
> and SPI_MOSI_IDLE_LOW. Due to the length of the new options, the
> indentation of the options in the help message was also adjusted for all
> other options.
Actually since you are touching all of them in the user-visible
output, you may also reshuffle them to be grouped logically. I'm not
sure if the switch-case ordering would be nice to have shuffled as
well. If so, in this case it might be better to have it as a
preparatory patch before you adding new options (and hence take care
of indentation in the first patch). That said, just think about it,
I'm not insisting.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists