linux-kernel - Re: [PATCH] tty: serial: fsl_lpuart: Check the return value of dmaengine_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2023052225-slimy-struggle-6fee@gregkh>
Date:   Mon, 22 May 2023 17:20:40 +0100
From:   "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:     Shenwei Wang <shenwei.wang@....com>
Cc:     Sherry Sun <sherry.sun@....com>,
        "jirislaby@...nel.org" <jirislaby@...nel.org>,
        "ilpo.jarvinen@...ux.intel.com" <ilpo.jarvinen@...ux.intel.com>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH] tty: serial: fsl_lpuart: Check the return value of
 dmaengine_tx_status

On Mon, May 22, 2023 at 02:45:12PM +0000, Shenwei Wang wrote:
> 
> 
> > -----Original Message-----
> > From: Sherry Sun <sherry.sun@....com>
> > Sent: Sunday, May 21, 2023 9:51 PM
> > To: gregkh@...uxfoundation.org; jirislaby@...nel.org; Shenwei Wang
> > <shenwei.wang@....com>; ilpo.jarvinen@...ux.intel.com
> > Cc: linux-serial@...r.kernel.org; linux-kernel@...r.kernel.org; dl-linux-imx
> > <linux-imx@....com>
> > Subject: [PATCH] tty: serial: fsl_lpuart: Check the return value of
> > dmaengine_tx_status
> > 
> > Coverity reports the Unchecked return value (CHECKED_RETURN) warning:
> > Calling dmaengine_tx_status without checking return value.
> > 
> > So here add the return value check for dmaengine_tx_status() function to make
> > coverity happy.
> > 
> > Fixes: cf9aa72d2f91 ("tty: serial: fsl_lpuart: optimize the timer based EOP logic")
> > Signed-off-by: Sherry Sun <sherry.sun@....com>
> > ---
> >  drivers/tty/serial/fsl_lpuart.c | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index
> > 92a3bd0f4158..f2a47a8c5b85 100644
> > --- a/drivers/tty/serial/fsl_lpuart.c
> > +++ b/drivers/tty/serial/fsl_lpuart.c
> > @@ -1286,13 +1286,19 @@ static void lpuart_dma_rx_complete(void *arg)
> > static void lpuart_timer_func(struct timer_list *t)  {
> >  	struct lpuart_port *sport = from_timer(sport, t, lpuart_timer);
> > +	enum dma_status dmastat;
> 
> Should be reverse Christmas tree order.

Not a requirement at all, please don't force it.

thanks,

greg k-h