linux-kernel - RE: [PATCH] tty: serial: fsl_lpuart: Check the return value of dmaengine_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PAXPR04MB918546704F3DB435675B747A89439@PAXPR04MB9185.eurprd04.prod.outlook.com>
Date:   Mon, 22 May 2023 14:45:12 +0000
From:   Shenwei Wang <shenwei.wang@....com>
To:     Sherry Sun <sherry.sun@....com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "jirislaby@...nel.org" <jirislaby@...nel.org>,
        "ilpo.jarvinen@...ux.intel.com" <ilpo.jarvinen@...ux.intel.com>
CC:     "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH] tty: serial: fsl_lpuart: Check the return value of
 dmaengine_tx_status



> -----Original Message-----
> From: Sherry Sun <sherry.sun@....com>
> Sent: Sunday, May 21, 2023 9:51 PM
> To: gregkh@...uxfoundation.org; jirislaby@...nel.org; Shenwei Wang
> <shenwei.wang@....com>; ilpo.jarvinen@...ux.intel.com
> Cc: linux-serial@...r.kernel.org; linux-kernel@...r.kernel.org; dl-linux-imx
> <linux-imx@....com>
> Subject: [PATCH] tty: serial: fsl_lpuart: Check the return value of
> dmaengine_tx_status
> 
> Coverity reports the Unchecked return value (CHECKED_RETURN) warning:
> Calling dmaengine_tx_status without checking return value.
> 
> So here add the return value check for dmaengine_tx_status() function to make
> coverity happy.
> 
> Fixes: cf9aa72d2f91 ("tty: serial: fsl_lpuart: optimize the timer based EOP logic")
> Signed-off-by: Sherry Sun <sherry.sun@....com>
> ---
>  drivers/tty/serial/fsl_lpuart.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index
> 92a3bd0f4158..f2a47a8c5b85 100644
> --- a/drivers/tty/serial/fsl_lpuart.c
> +++ b/drivers/tty/serial/fsl_lpuart.c
> @@ -1286,13 +1286,19 @@ static void lpuart_dma_rx_complete(void *arg)
> static void lpuart_timer_func(struct timer_list *t)  {
>  	struct lpuart_port *sport = from_timer(sport, t, lpuart_timer);
> +	enum dma_status dmastat;

Should be reverse Christmas tree order.

Regards,
Shenwei

>  	struct dma_chan *chan = sport->dma_rx_chan;
>  	struct circ_buf *ring = &sport->rx_ring;
>  	struct dma_tx_state state;
>  	unsigned long flags;
>  	int count;
> 
> -	dmaengine_tx_status(chan, sport->dma_rx_cookie, &state);
> +	dmastat = dmaengine_tx_status(chan, sport->dma_rx_cookie, &state);
> +	if (dmastat == DMA_ERROR) {
> +		dev_err(sport->port.dev, "Rx DMA transfer failed!\n");
> +		return;
> +	}
> +
>  	ring->head = sport->rx_sgl.length - state.residue;
>  	count = CIRC_CNT(ring->head, ring->tail, sport->rx_sgl.length);
> 
> --
> 2.17.1