linux-kernel - RE: [PATCH] drm/amd/pm: Replace all non-returning strlcpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BL1PR12MB51441977ABB724A43D4B54B7F7439@BL1PR12MB5144.namprd12.prod.outlook.com>
Date:   Mon, 22 May 2023 20:35:17 +0000
From:   "Deucher, Alexander" <Alexander.Deucher@....com>
To:     Kees Cook <keescook@...omium.org>,
        Azeem Shaikh <azeemshaikh38@...il.com>
CC:     "Quan, Evan" <Evan.Quan@....com>,
        "linux-hardening@...r.kernel.org" <linux-hardening@...r.kernel.org>,
        "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Koenig, Christian" <Christian.Koenig@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>
Subject: RE: [PATCH] drm/amd/pm: Replace all non-returning strlcpy with
 strscpy

[Public]

> -----Original Message-----
> From: Kees Cook <keescook@...omium.org>
> Sent: Monday, May 22, 2023 4:16 PM
> To: Azeem Shaikh <azeemshaikh38@...il.com>
> Cc: Quan, Evan <Evan.Quan@....com>; linux-hardening@...r.kernel.org;
> amd-gfx@...ts.freedesktop.org; linux-kernel@...r.kernel.org; Deucher,
> Alexander <Alexander.Deucher@....com>; Koenig, Christian
> <Christian.Koenig@....com>; Pan, Xinhui <Xinhui.Pan@....com>; David
> Airlie <airlied@...il.com>; Daniel Vetter <daniel@...ll.ch>; dri-
> devel@...ts.freedesktop.org
> Subject: Re: [PATCH] drm/amd/pm: Replace all non-returning strlcpy with
> strscpy
> 
> On Mon, May 22, 2023 at 03:52:45PM +0000, Azeem Shaikh wrote:
> > strlcpy() reads the entire source buffer first.
> > This read may exceed the destination size limit.
> > This is both inefficient and can lead to linear read overflows if a
> > source string is not NUL-terminated [1].
> > In an effort to remove strlcpy() completely [2], replace
> > strlcpy() here with strscpy().
> > No return values were used, so direct replacement is safe.
> >
> > [1]
> >
> https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> > [2] https://github.com/KSPP/linux/issues/89
> >
> > Signed-off-by: Azeem Shaikh <azeemshaikh38@...il.com>
> 
> Reviewed-by: Kees Cook <keescook@...omium.org>
> 

Acked-by: Alex Deucher <alexander.deucher@....com>

Ack to take this through whatever tree makes sense if you are trying to batch all of these up.  Otherwise, I can pick them up.

Alex