linux-kernel - Re: [PATCH] regmap: sdw: check for invalid multi-register writes config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dd2d2484-13f9-4fa6-85d2-5a540f137b3a@sirena.org.uk>
Date:   Tue, 23 May 2023 17:58:02 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     gregkh@...uxfoundation.org, rafael@...nel.org,
        ckeepax@...nsource.cirrus.com, tanureal@...nsource.cirrus.com,
        linux-kernel@...r.kernel.org, alsa-devel@...a-project.org
Subject: Re: [PATCH] regmap: sdw: check for invalid multi-register writes
 config

On Tue, May 23, 2023 at 04:47:47PM +0100, Srinivas Kandagatla wrote:

> +	/* Only bulk writes are supported not multi-register writes */
> +	if (config->can_multi_write)
> +		return -ENOTSUPP;
> +

This doesn't seem like the right fix - I'd expect us to simply choose
not to use multiple writes, with an additional flag/check for bus
support.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)