linux-kernel - Re: [PATCH] regmap: sdw: check for invalid multi-register writes config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f34ca48-75cc-d824-2230-7375146ad970@linaro.org>
Date:   Tue, 23 May 2023 18:13:25 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     gregkh@...uxfoundation.org, rafael@...nel.org,
        ckeepax@...nsource.cirrus.com, tanureal@...nsource.cirrus.com,
        linux-kernel@...r.kernel.org, alsa-devel@...a-project.org
Subject: Re: [PATCH] regmap: sdw: check for invalid multi-register writes
 config



On 23/05/2023 17:58, Mark Brown wrote:
> On Tue, May 23, 2023 at 04:47:47PM +0100, Srinivas Kandagatla wrote:
> 
>> +	/* Only bulk writes are supported not multi-register writes */
>> +	if (config->can_multi_write)
>> +		return -ENOTSUPP;
>> +
> 
> This doesn't seem like the right fix - I'd expect us to simply choose
> not to use multiple writes, with an additional flag/check for bus
> support.
Is there a way to check if bus support multi-register writes?

All I can see from the code is that regmap can_multi_write is set based 
on regmap_config from device and write callback from bus.


--srini