linux-kernel - Re: [PATCH net-next v4 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <168488029701.2003121.3742030688630968396.robh@kernel.org>
Date:   Tue, 23 May 2023 17:18:17 -0500
From:   Rob Herring <robh@...nel.org>
To:     Justin Chen <justin.chen@...adcom.com>
Cc:     kuba@...nel.org, hkallweit1@...il.com, davem@...emloft.net,
        sumit.semwal@...aro.org, netdev@...r.kernel.org,
        linux@...linux.org.uk, bcm-kernel-feedback-list@...adcom.com,
        christian.koenig@....com, opendmb@...il.com, robh+dt@...nel.org,
        conor@...nel.org, justinpopo6@...il.com, richardcochran@...il.com,
        Florian Fainelli <florian.fainelli@...adcom.com>,
        f.fainelli@...il.com, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, krzysztof.kozlowski+dt@...aro.org,
        edumazet@...gle.com, andrew@...n.ch, simon.horman@...igine.com,
        devicetree@...r.kernel.org, pabeni@...hat.com
Subject: Re: [PATCH net-next v4 2/6] dt-bindings: net: Brcm ASP 2.0
 Ethernet controller


On Tue, 23 May 2023 14:53:43 -0700, Justin Chen wrote:
> From: Florian Fainelli <florian.fainelli@...adcom.com>
> 
> Add a binding document for the Broadcom ASP 2.0 Ethernet
> controller.
> 
> Signed-off-by: Florian Fainelli <florian.fainelli@...adcom.com>
> Signed-off-by: Justin Chen <justin.chen@...adcom.com>
> ---
> v3
> 	- Adjust compatible string example to reference SoC and HW ver
> 
> v3
>         - Minor formatting issues
>         - Change channel prop to brcm,channel for vendor specific format
>         - Removed redundant v2.0 from compat string
>         - Fix ranges field
> 
> v2
>         - Minor formatting issues
> 
>  .../devicetree/bindings/net/brcm,asp-v2.0.yaml     | 145 +++++++++++++++++++++
>  1 file changed, 145 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/brcm,asp-v2.0.example.dtb: ethernet@...0000: compatible: ['brcm,bcm72165-asp', 'brcm,asp-v2.0'] is too long
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1684878827-40672-3-git-send-email-justin.chen@broadcom.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.