linux-kernel - Re: [PATCH] watchdog: set variables watchdog_soft,hardlockup_user_enabled storage-class-specifier to static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1dde2e80-c28d-5782-a5fa-c222af1db8bc@quicinc.com>
Date:   Tue, 23 May 2023 18:10:05 +0530
From:   Mukesh Ojha <quic_mojha@...cinc.com>
To:     Tom Rix <trix@...hat.com>, <akpm@...ux-foundation.org>,
        <dianders@...omium.org>, <pmladek@...e.com>,
        <kernelfans@...il.com>, <lecopzer.chen@...iatek.com>,
        <ldufour@...ux.ibm.com>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] watchdog: set variables
 watchdog_soft,hardlockup_user_enabled storage-class-specifier to static



On 5/23/2023 5:53 PM, Tom Rix wrote:
> smatch reports
> kernel/watchdog.c:40:19: warning: symbol
>    'watchdog_hardlockup_user_enabled' was not declared. Should it be static?
> kernel/watchdog.c:41:19: warning: symbol
>    'watchdog_softlockup_user_enabled' was not declared. Should it be static?
> 
> These variabled are only used in their defining file, so it should be static.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

Reviewed-by: Mukesh Ojha <quic_mojha@...cinc.com>

-- Mukesh

> ---
>   kernel/watchdog.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/watchdog.c b/kernel/watchdog.c
> index 877d8670f26e..237990e8d345 100644
> --- a/kernel/watchdog.c
> +++ b/kernel/watchdog.c
> @@ -37,8 +37,8 @@ static DEFINE_MUTEX(watchdog_mutex);
>   
>   unsigned long __read_mostly watchdog_enabled;
>   int __read_mostly watchdog_user_enabled = 1;
> -int __read_mostly watchdog_hardlockup_user_enabled = WATCHDOG_HARDLOCKUP_DEFAULT;
> -int __read_mostly watchdog_softlockup_user_enabled = 1;
> +static int __read_mostly watchdog_hardlockup_user_enabled = WATCHDOG_HARDLOCKUP_DEFAULT;
> +static int __read_mostly watchdog_softlockup_user_enabled = 1;
>   int __read_mostly watchdog_thresh = 10;
>   static int __read_mostly watchdog_hardlockup_available;
>