linux-kernel - Re: [PATCH v1] usb: xhci: plat: remove error log for failure to get usb-phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZGy0eTd708Yyx_z5@hovoldconsulting.com>
Date:   Tue, 23 May 2023 14:41:29 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Stanley Chang <stanley_chang@...ltek.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Klaus Kudielka <klaus.kudielka@...il.com>,
        Mathias Nyman <mathias.nyman@...el.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] usb: xhci: plat: remove error log for failure to get
 usb-phy

On Wed, May 10, 2023 at 03:51:29PM +0800, Stanley Chang wrote:
> Remove this log to avoid non-error conditions.
> If CONFIG_USB_PHY is disabled, the following error message appears:
> [    0.231609] xhci-hcd f10f0000.usb3: xhci_plat_probe get usb3phy fail (ret=-6)
> [    0.239716] xhci-hcd f10f8000.usb3: xhci_plat_probe get usb3phy fail (ret=-6)
> In this case, devm_usb_get_phy_by_phandle is declared static inline
> and returns -ENXIO.
> 
> It is easy to pinpoint the failure to get the usb-phy using the debug
> log in drivers/usb/phy/phy.c. Therefore, it can be removed.
> 
> Signed-off-by: Stanley Chang <stanley_chang@...ltek.com>

This one fixes the annoying bogus error messages that started showing up
in 6.4-rc on the Lenovo X13s and other machines not using the legacy PHY
drivers:

Fixes: 9134c1fd0503 ("usb: xhci: plat: Add USB 3.0 phy support")
Reviewed-by: Johan Hovold <johan+linaro@...nel.org>
Tested-by: Johan Hovold <johan+linaro@...nel.org>

Greg, I noticed you applied this one for 6.5; any chance we could get
this fixed already in 6.4 which has the offending commit?

> ---
>  drivers/usb/host/xhci-plat.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index b0c8e8efc43b..6a45ee431945 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -294,10 +294,6 @@ int xhci_plat_probe(struct platform_device *pdev, struct device *sysdev, const s
>  		xhci->shared_hcd->usb_phy = devm_usb_get_phy_by_phandle(sysdev,
>  			    "usb-phy", 1);
>  		if (IS_ERR(xhci->shared_hcd->usb_phy)) {
> -			if (PTR_ERR(xhci->shared_hcd->usb_phy) != -ENODEV)
> -				dev_err(sysdev, "%s get usb3phy fail (ret=%d)\n",
> -					     __func__,
> -					    (int)PTR_ERR(xhci->shared_hcd->usb_phy));
>  			xhci->shared_hcd->usb_phy = NULL;
>  		} else {
>  			ret = usb_phy_init(xhci->shared_hcd->usb_phy);

Johan