linux-kernel - Re: [PATCH 2/2] signal: move show_unhandled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d0fe7a6f-8cd9-0b81-758a-f3b444e74bab@intel.com>
Date:   Tue, 23 May 2023 07:16:55 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     Luis Chamberlain <mcgrof@...nel.org>, keescook@...omium.org,
        yzaikin@...gle.com, ebiederm@...ssion.com, arnd@...db.de,
        bp@...en8.de, James.Bottomley@...senPartnership.com, deller@....de,
        tglx@...utronix.de, mingo@...hat.com, dave.hansen@...ux.intel.com,
        x86@...nel.org, hpa@...or.com, luto@...nel.org,
        peterz@...radead.org, brgerst@...il.com,
        christophe.jaillet@...adoo.fr, kirill.shutemov@...ux.intel.com,
        jroedel@...e.de
Cc:     j.granados@...sung.com, akpm@...ux-foundation.org,
        willy@...radead.org, linux-parisc@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] signal: move show_unhandled_signals sysctl to its own
 file

On 5/22/23 14:08, Luis Chamberlain wrote:
> --- a/arch/x86/kernel/umip.c
> +++ b/arch/x86/kernel/umip.c
> @@ -12,6 +12,7 @@
>  #include <asm/insn.h>
>  #include <asm/insn-eval.h>
>  #include <linux/ratelimit.h>
> +#include <linux/signal.h>

Oh, so this is actually fixing a bug: umip.c uses
'show_unhandled_signals' but it doesn't explicitly include
linux/signal.h where 'show_unhandled_signals' is declared.

It doesn't actually have anything to do with moving the
show_unhandled_signals sysctl, right?

If that's the case, it would be nice to have this in its own patch.