linux-kernel - Re: [PATCH 2/2] signal: move show_unhandled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZG29HWE9NWn56hTg@bombadil.infradead.org>
Date:   Wed, 24 May 2023 00:30:37 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Dave Hansen <dave.hansen@...el.com>
Cc:     keescook@...omium.org, yzaikin@...gle.com, ebiederm@...ssion.com,
        arnd@...db.de, bp@...en8.de, James.Bottomley@...senpartnership.com,
        deller@....de, tglx@...utronix.de, mingo@...hat.com,
        dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com,
        luto@...nel.org, peterz@...radead.org, brgerst@...il.com,
        christophe.jaillet@...adoo.fr, kirill.shutemov@...ux.intel.com,
        jroedel@...e.de, j.granados@...sung.com, akpm@...ux-foundation.org,
        willy@...radead.org, linux-parisc@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] signal: move show_unhandled_signals sysctl to its
 own file

On Tue, May 23, 2023 at 07:16:55AM -0700, Dave Hansen wrote:
> On 5/22/23 14:08, Luis Chamberlain wrote:
> > --- a/arch/x86/kernel/umip.c
> > +++ b/arch/x86/kernel/umip.c
> > @@ -12,6 +12,7 @@
> >  #include <asm/insn.h>
> >  #include <asm/insn-eval.h>
> >  #include <linux/ratelimit.h>
> > +#include <linux/signal.h>
> 
> Oh, so this is actually fixing a bug: umip.c uses
> 'show_unhandled_signals' but it doesn't explicitly include
> linux/signal.h where 'show_unhandled_signals' is declared.

Fixes a non-critical bug perhaps, but I doubt it would be fixing
a functional bug as otherwise folks would have reported a build bug, no?

What or how it ends up including that file today to avoid build
failures is beyond me.

> It doesn't actually have anything to do with moving the
> show_unhandled_signals sysctl, right?

Well in my case it is making sure the sysctl variable used is declared
as well.

> If that's the case, it would be nice to have this in its own patch.

If its not really fixing any build bugs or functional bugs I don't see
the need. But if you really want it, I can do it.

Let me know!

  Luis