linux-kernel - Re: [PATCH] md/raid5: fix miscalculation of 'end_sector' in raid5_read_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7075bfd8-7c52-a778-5651-71ade3cd1f03@kernel.dk>
Date:   Wed, 24 May 2023 09:03:17 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Yu Kuai <yukuai1@...weicloud.com>, hch@....de, song@...nel.org,
        chaitanya.kulkarni@....com, johannes.thumshirn@....com,
        damien.lemoal@....com
Cc:     linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org,
        yukuai3@...wei.com, yi.zhang@...wei.com, yangerkun@...wei.com
Subject: Re: [PATCH] md/raid5: fix miscalculation of 'end_sector' in
 raid5_read_one_chunk()

On 5/23/23 7:41 PM, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@...wei.com>
> 
> 'end_sector' is compared to 'rdev->recovery_offset', which is offset to
> rdev, however, commit e82ed3a4fbb5 ("md/raid6: refactor
> raid5_read_one_chunk") changes the calculation of 'end_sector' to offset
> to the array. Fix this miscalculation.
> 
> Fixes: e82ed3a4fbb5 ("md/raid6: refactor raid5_read_one_chunk")

This needs a stable tag as well, Fixes alone is not enough to guarantee
it ends up in stable.

Song, are you picking this up?

-- 
Jens Axboe