linux-kernel - Re: [PATCH] md/raid5: fix miscalculation of 'end_sector' in raid5_read_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPhsuW5cBZUdBFM7jdfP11ev5UpQX_YCe_EmR+A1B4XgSrw+-w@mail.gmail.com>
Date:   Wed, 24 May 2023 10:21:40 -0700
From:   Song Liu <song@...nel.org>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     Yu Kuai <yukuai1@...weicloud.com>, hch@....de,
        chaitanya.kulkarni@....com, johannes.thumshirn@....com,
        damien.lemoal@....com, linux-raid@...r.kernel.org,
        linux-kernel@...r.kernel.org, yukuai3@...wei.com,
        yi.zhang@...wei.com, yangerkun@...wei.com
Subject: Re: [PATCH] md/raid5: fix miscalculation of 'end_sector' in raid5_read_one_chunk()

On Wed, May 24, 2023 at 8:03 AM Jens Axboe <axboe@...nel.dk> wrote:
>
> On 5/23/23 7:41 PM, Yu Kuai wrote:
> > From: Yu Kuai <yukuai3@...wei.com>
> >
> > 'end_sector' is compared to 'rdev->recovery_offset', which is offset to
> > rdev, however, commit e82ed3a4fbb5 ("md/raid6: refactor
> > raid5_read_one_chunk") changes the calculation of 'end_sector' to offset
> > to the array. Fix this miscalculation.
> >
> > Fixes: e82ed3a4fbb5 ("md/raid6: refactor raid5_read_one_chunk")
>
> This needs a stable tag as well, Fixes alone is not enough to guarantee
> it ends up in stable.
>
> Song, are you picking this up?

Yes, I will test it and send it via md-fixes.

Thanks,
Song