linux-kernel - Re: [PATCH AUTOSEL 6.2 08/30] selftests/bpf: check that modifier resolves after pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAN+4W8iMcwwVjmSekZ9txzZNxOZ0x98nBXo4cEoTU9G2zLe8HA@mail.gmail.com>
Date:   Wed, 24 May 2023 18:04:43 +0100
From:   Lorenz Bauer <lmb@...valent.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Sasha Levin <sashal@...nel.org>, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org, Martin KaFai Lau <martin.lau@...nel.org>,
        ast@...nel.org, daniel@...earbox.net, andrii@...nel.org,
        shuah@...nel.org, yhs@...com, eddyz87@...il.com, sdf@...gle.com,
        error27@...il.com, iii@...ux.ibm.com, memxor@...il.com,
        bpf@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 6.2 08/30] selftests/bpf: check that modifier
 resolves after pointer

On Wed, May 24, 2023 at 5:04 PM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> Great, any specific commits that fix this issue would be appreciated to
> be pointed at so we can apply them.

The problem was introduced by commit f4b8c0710ab6 ("selftests/bpf: Add
verifier test for release_reference()") in your tree. Seems like
fixup_map_ringbuf was introduced in upstream commit 4237e9f4a962
("selftests/bpf: Add verifier test for PTR_TO_MEM spill") but that
wasn't backported.

To restate my original question: how can we avoid breaking BPF
selftests? From personal experience this happens somewhat regularly.

Best
Lorenz