linux-kernel - Re: [Linux-kernel-mentorship] [PATCH] selftest: pidfd: Omit long and repeating outputs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230524-tausend-erlitt-b3163dd1dd05@brauner>
Date:   Wed, 24 May 2023 11:12:01 +0200
From:   Christian Brauner <brauner@...nel.org>
To:     Ziqi Zhao <astrajoan@...oo.com>
Cc:     skhan@...uxfoundation.org, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org
Subject: Re: [Linux-kernel-mentorship] [PATCH] selftest: pidfd: Omit long and
 repeating outputs

On Tue, May 23, 2023 at 11:22:07PM +0000, Ziqi Zhao wrote:
> An output message:
> 
> > # # waitpid WEXITSTATUS=0
> 
> will be printed for 30,000+ times in the `pidfd_test` selftest, which
> does not seem ideal. This patch removes the print logic in the
> `wait_for_pid` function, so each call to this function does not output
> a line by default. Any existing call sites where the extra line might
> be beneficial have been modified to include extra print statements
> outside of the function calls.
> 
> Signed-off-by: Ziqi Zhao <astrajoan@...oo.com>
> ---

Fine by me,
Reviewed-by: Christian Brauner <brauner@...nel.org>