linux-kernel - Re: [Linux-kernel-mentorship] [PATCH] selftest: pidfd: Omit long and repeating outputs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <33481784-f1c8-cc0f-4c68-404efcf2258d@linuxfoundation.org>
Date:   Mon, 5 Jun 2023 13:26:49 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Christian Brauner <brauner@...nel.org>,
        Ziqi Zhao <astrajoan@...oo.com>
Cc:     linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [Linux-kernel-mentorship] [PATCH] selftest: pidfd: Omit long and
 repeating outputs

On 5/24/23 03:12, Christian Brauner wrote:
> On Tue, May 23, 2023 at 11:22:07PM +0000, Ziqi Zhao wrote:
>> An output message:
>>
>>> # # waitpid WEXITSTATUS=0
>>
>> will be printed for 30,000+ times in the `pidfd_test` selftest, which
>> does not seem ideal. This patch removes the print logic in the
>> `wait_for_pid` function, so each call to this function does not output
>> a line by default. Any existing call sites where the extra line might
>> be beneficial have been modified to include extra print statements
>> outside of the function calls.
>>
>> Signed-off-by: Ziqi Zhao <astrajoan@...oo.com>
>> ---
> 
> Fine by me,
> Reviewed-by: Christian Brauner <brauner@...nel.org>

Thank you. Applied to linux-kselftest next for Linux 6.5-rc1.

thanks,
-- Shuah