linux-kernel - Re: [PATCH v2 10/11] selftests/mm: move uffd* routines from vm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9d69977d-c384-aa4b-c09a-43ffd1f8ec76@nvidia.com>
Date:   Mon, 5 Jun 2023 12:28:31 -0700
From:   John Hubbard <jhubbard@...dia.com>
To:     Peter Xu <peterx@...hat.com>
CC:     Andrew Morton <akpm@...ux-foundation.org>,
        David Hildenbrand <david@...hat.com>,
        Shuah Khan <shuah@...nel.org>,
        Nathan Chancellor <nathan@...nel.org>, <linux-mm@...ck.org>,
        <linux-kselftest@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 10/11] selftests/mm: move uffd* routines from vm_util.c
 to uffd-common.c

On 6/5/23 12:24, Peter Xu wrote:
...
>> It sounds like you are suggesting this:
>>
>> $(OUTPUT)/uffd-stress:          uffd-common.c uffd-test-common.c
>> $(OUTPUT)/uffd-unit-tests:      uffd-common.c uffd-test-common.c
>> $(OUTPUT)/hugepage-mremap:      uffd-test-common.c
>> $(OUTPUT)/write_to_hugetlbfs:   uffd-test-common.c
>> $(OUTPUT)/ksm_functional_tests: uffd-test-common.c
>>
>> ...approximately. Do I have that correct? I can arrange it that way
>> if you feel it's a better end result. (And it's better than leaving
>> uffd*() helpers in vm_utils, imho.)
> 
> Yes, as long as we don't link (especially) the uffd test specific globals
> into non-uffd test programs I'll have no issue.  Thanks.
> 

OK very good. I'll put that together.


thanks,
-- 
John Hubbard
NVIDIA