lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZG3biep8vAWQ5ZgA@gondor.apana.org.au>
Date:   Wed, 24 May 2023 17:40:25 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Jia Jie Ho <jiajie.ho@...rfivetech.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org
Subject: Re: [PATCH 2/2] crypto: starfive - Add RSA algo support

On Tue, May 16, 2023 at 03:57:52PM +0800, Jia Jie Ho wrote:
>
> +static struct akcipher_alg starfive_rsa = {
> +	.encrypt = starfive_rsa_enc,
> +	.decrypt = starfive_rsa_dec,
> +	.sign = starfive_rsa_dec,
> +	.verify = starfive_rsa_enc,
> +	.set_pub_key = starfive_rsa_set_pub_key,
> +	.set_priv_key = starfive_rsa_set_priv_key,
> +	.max_size = starfive_rsa_max_size,
> +	.init = starfive_rsa_init_tfm,
> +	.exit = starfive_rsa_exit_tfm,
> +	.base = {
> +		.cra_name = "rsa",
> +		.cra_driver_name = "starfive-rsa",
> +		.cra_flags = CRYPTO_ALG_TYPE_AKCIPHER |
> +			     CRYPTO_ALG_ASYNC |

Why did you set the ASYNC flag? Your implementation appears to
be completely synchronous.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ