linux-kernel - Re: [PATCH 2/2] crypto: starfive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <29d515ec-83aa-c13e-b491-bc2ab7454012@starfivetech.com>
Date:   Thu, 25 May 2023 09:56:03 +0800
From:   Jia Jie Ho <jiajie.ho@...rfivetech.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
CC:     "David S . Miller" <davem@...emloft.net>,
        <linux-kernel@...r.kernel.org>, <linux-crypto@...r.kernel.org>
Subject: Re: [PATCH 2/2] crypto: starfive - Add RSA algo support

On 24/5/2023 5:40 pm, Herbert Xu wrote:
> On Tue, May 16, 2023 at 03:57:52PM +0800, Jia Jie Ho wrote:
>>
>> +static struct akcipher_alg starfive_rsa = {
>> +	.encrypt = starfive_rsa_enc,
>> +	.decrypt = starfive_rsa_dec,
>> +	.sign = starfive_rsa_dec,
>> +	.verify = starfive_rsa_enc,
>> +	.set_pub_key = starfive_rsa_set_pub_key,
>> +	.set_priv_key = starfive_rsa_set_priv_key,
>> +	.max_size = starfive_rsa_max_size,
>> +	.init = starfive_rsa_init_tfm,
>> +	.exit = starfive_rsa_exit_tfm,
>> +	.base = {
>> +		.cra_name = "rsa",
>> +		.cra_driver_name = "starfive-rsa",
>> +		.cra_flags = CRYPTO_ALG_TYPE_AKCIPHER |
>> +			     CRYPTO_ALG_ASYNC |
> 
> Why did you set the ASYNC flag? Your implementation appears to
> be completely synchronous.
> 

I mixed this up with other modules, will remove this in next version.

Thanks,
Jia Jie