linux-kernel - Re: [PATCH 7/8] ARM: dts: stm32: adopt generic iio bindings for adc channels on dhcor-drc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc7a0a1a-31bb-92f4-6365-5e0c4a4bc85c@denx.de>
Date:   Wed, 24 May 2023 15:54:24 +0200
From:   Marek Vasut <marex@...x.de>
To:     Olivier Moysan <olivier.moysan@...s.st.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>
Cc:     kernel@...electronics.com, devicetree@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/8] ARM: dts: stm32: adopt generic iio bindings for adc
 channels on dhcor-drc

On 5/24/23 15:39, Olivier Moysan wrote:
> Use STM32 ADC generic bindings instead of legacy bindings on
> DHCOR DRC Compact board.
> 
> The STM32 ADC specific binding to declare channels has been deprecated,
> hence adopt the generic IIO channels bindings, instead.
> The STM32MP151 device tree now exposes internal channels using the
> generic binding. This makes the change mandatory here to avoid a mixed
> use of legacy and generic binding, which is not supported by the driver.
> 
> Signed-off-by: Olivier Moysan <olivier.moysan@...s.st.com>
> ---
>   .../dts/stm32mp15xx-dhcor-drc-compact.dtsi    | 28 ++++++++++++++++---
>   1 file changed, 24 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcor-drc-compact.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcor-drc-compact.dtsi
> index 39af79dc654c..92d906bfd5d7 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-dhcor-drc-compact.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcor-drc-compact.dtsi
> @@ -57,15 +57,35 @@ &adc {	/* X11 ADC inputs */
>   	status = "okay";
>   
>   	adc1: adc@0 {


I sent similar patch recently too:

[PATCH] ARM: dts: stm32: Update to generic ADC channel binding on DHSOM 
systems

But I needed to add #address-cells/#size-cells here and to adc@100, 
otherwise DTB checker was complaining . Did you run DTB check and was it 
OK on your side ?

> -		st,adc-channels = <0 1 6>;
> -		st,min-sample-time-nsecs = <5000>;
>   		status = "okay";
> +		channel@0 {
> +			reg = <0>;
> +			st,min-sample-time-ns = <5000>;
> +		};
> +		channel@1 {
> +			reg = <1>;
> +			st,min-sample-time-ns = <5000>;
> +		};
> +		channel@6 {
> +			reg = <6>;
> +			st,min-sample-time-ns = <5000>;
> +		};
>   	};

[...]