[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5b8700fb-d455-469e-a34d-62cb6f68d324@roeck-us.net>
Date: Thu, 25 May 2023 11:17:17 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Osama Muhammad <osmtendev@...il.com>
Cc: jdelvare@...e.com, linux-hwmon@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] adm1266.c: Drop error checking for debugfs_create_dir
On Thu, May 25, 2023 at 09:08:27PM +0500, Osama Muhammad wrote:
> This patch fixes the error checking in adm1266.c.
> The DebugFS kernel API is developed in
> a way that the caller can safely ignore the errors that
> occur during the creation of DebugFS nodes.
>
> Signed-off-by: Osama Muhammad <osmtendev@...il.com>
Confusing. Is this v3 of the patch ?
Guenter
> ---
> drivers/hwmon/pmbus/adm1266.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/hwmon/pmbus/adm1266.c b/drivers/hwmon/pmbus/adm1266.c
> index 1ac2b2f4c570..184d75269d2b 100644
> --- a/drivers/hwmon/pmbus/adm1266.c
> +++ b/drivers/hwmon/pmbus/adm1266.c
> @@ -340,8 +340,6 @@ static void adm1266_init_debugfs(struct adm1266_data *data)
> return;
>
> data->debugfs_dir = debugfs_create_dir(data->client->name, root);
> - if (!data->debugfs_dir)
> - return;
>
> debugfs_create_devm_seqfile(&data->client->dev, "sequencer_state", data->debugfs_dir,
> adm1266_state_read);
> --
> 2.34.1
>
Powered by blists - more mailing lists