linux-kernel - Re: [PATCH] adm1266.c: Drop error checking for debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 25 May 2023 23:22:33 +0500
From:   Osama Muhammad <osmtendev@...il.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     jdelvare@...e.com, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] adm1266.c: Drop error checking for debugfs_create_dir

This is the new patch not v3. The patch I sent as v2 was a mistake.
Please discard the patch I sent earlier as v2 .
Apologies for the confusion.Hope it clarifies.

Regards,
Osmten



On Thu, 25 May 2023 at 23:17, Guenter Roeck <linux@...ck-us.net> wrote:
>
> On Thu, May 25, 2023 at 09:08:27PM +0500, Osama Muhammad wrote:
> > This patch fixes the error checking in adm1266.c.
> > The DebugFS kernel API is developed in
> > a way that the caller can safely ignore the errors that
> > occur during the creation of DebugFS nodes.
> >
> > Signed-off-by: Osama Muhammad <osmtendev@...il.com>
>
> Confusing. Is this v3 of the patch ?
>
> Guenter
>
> > ---
> >  drivers/hwmon/pmbus/adm1266.c | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/hwmon/pmbus/adm1266.c b/drivers/hwmon/pmbus/adm1266.c
> > index 1ac2b2f4c570..184d75269d2b 100644
> > --- a/drivers/hwmon/pmbus/adm1266.c
> > +++ b/drivers/hwmon/pmbus/adm1266.c
> > @@ -340,8 +340,6 @@ static void adm1266_init_debugfs(struct adm1266_data *data)
> >               return;
> >
> >       data->debugfs_dir = debugfs_create_dir(data->client->name, root);
> > -     if (!data->debugfs_dir)
> > -             return;
> >
> >       debugfs_create_devm_seqfile(&data->client->dev, "sequencer_state", data->debugfs_dir,
> >                                   adm1266_state_read);
> > --
> > 2.34.1
> >