linux-kernel - Re: [PATCHv2 3/6] hwmon: (socfpga) Add hardware monitoring support on SoCFPGA platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b36bd5d9-a7dc-b478-9b89-ed3b10bd6725@linux.intel.com>
Date:   Thu, 25 May 2023 16:20:12 -0500
From:   Dinh Nguyen <dinh.nguyen@...ux.intel.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        linux-hwmon@...r.kernel.org
Cc:     dinguyen@...nel.org, devicetree@...r.kernel.org,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        linux-kernel@...r.kernel.org, jdelvare@...e.com,
        linux@...ck-us.net,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCHv2 3/6] hwmon: (socfpga) Add hardware monitoring support on
 SoCFPGA platforms

Hi Krzysztof,

On 5/9/2023 1:57 AM, Krzysztof Kozlowski wrote:
> On 08/05/2023 23:28, dinh.nguyen@...ux.intel.com wrote:
>> From: Dinh Nguyen <dinh.nguyen@...ux.intel.com>
>>
>> The driver supports 64-bit SoCFPGA platforms for temperature and voltage
>> reading using the platform's SDM(Secure Device Manager). The driver
>> also uses the Stratix10 Service layer driver.
>>
>> This driver only supports OF SoCFPGA 64-bit platforms.
>>
> (...)
>
>> +static int socfpga_probe_child_from_dt(struct device *dev,
>> +				       struct device_node *child,
>> +				       struct socfpga_hwmon_priv *priv)
>> +{
>> +	struct device_node *grandchild;
>> +	const char *label;
>> +	const char *type;
>> +	u32 val;
>> +	int ret;
>> +
>> +	if (of_property_read_string(child, "name", &type))
>> +		return dev_err_probe(dev, -EINVAL, "No type for %pOF\n", child);
>> +
>> +	for_each_child_of_node(child, grandchild) {
>> +		ret = of_property_read_u32(grandchild, "reg", &val);
>> +		if (ret)
>> +			return dev_err_probe(dev, ret, "missing reg property of %pOF\n",
>> +					     grandchild);
> Where do you drop child reference?

Not sure what you mean here? Can you clarify?

Thanks,

Dinh