linux-kernel - Re: [PATCHv2 3/6] hwmon: (socfpga) Add hardware monitoring support on SoCFPGA platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZHG/Mvb+Ivf87u/8@smile.fi.intel.com>
Date:   Sat, 27 May 2023 11:28:34 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Dinh Nguyen <dinh.nguyen@...ux.intel.com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        linux-hwmon@...r.kernel.org, dinguyen@...nel.org,
        devicetree@...r.kernel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, linux-kernel@...r.kernel.org,
        jdelvare@...e.com, linux@...ck-us.net
Subject: Re: [PATCHv2 3/6] hwmon: (socfpga) Add hardware monitoring support
 on SoCFPGA platforms

On Thu, May 25, 2023 at 04:20:12PM -0500, Dinh Nguyen wrote:
> On 5/9/2023 1:57 AM, Krzysztof Kozlowski wrote:
> > On 08/05/2023 23:28, dinh.nguyen@...ux.intel.com wrote:

> > > +	for_each_child_of_node(child, grandchild) {
> > > +		ret = of_property_read_u32(grandchild, "reg", &val);
> > > +		if (ret)
> > > +			return dev_err_probe(dev, ret, "missing reg property of %pOF\n",
> > > +					     grandchild);
> > Where do you drop child reference?
> 
> Not sure what you mean here? Can you clarify?

for_each_child_of_node() bumps a reference of the current (iterator) node, when
the loop is interrupted it's a user (of for_each macro) responsibility to drop
it.

-- 
With Best Regards,
Andy Shevchenko