linux-kernel - Re: [PATCH] arm64/cpufeature: Use helper for ECV CNTPOFF cpufeature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2898744e-1a67-5a8f-6adc-462d7f362b93@arm.com>
Date:   Thu, 25 May 2023 14:18:52 +0530
From:   Anshuman Khandual <anshuman.khandual@....com>
To:     Mark Brown <broonie@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64/cpufeature: Use helper for ECV CNTPOFF cpufeature



On 5/24/23 03:19, Mark Brown wrote:
> The newly added support for ECV CNTPOFF open codes the recently added
> helper ARM64_CPUID_FIELDS(), make use of the helper.  No functional
> change.
> 
> Signed-off-by: Mark Brown <broonie@...nel.org>

Reviewed-by: Anshuman Khandual <anshuman.khandual@....com>

> ---
>  arch/arm64/kernel/cpufeature.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
> index 7d7128c65161..27326f35b646 100644
> --- a/arch/arm64/kernel/cpufeature.c
> +++ b/arch/arm64/kernel/cpufeature.c
> @@ -2235,11 +2235,7 @@ static const struct arm64_cpu_capabilities arm64_features[] = {
>  		.capability = ARM64_HAS_ECV_CNTPOFF,
>  		.type = ARM64_CPUCAP_SYSTEM_FEATURE,
>  		.matches = has_cpuid_feature,
> -		.sys_reg = SYS_ID_AA64MMFR0_EL1,
> -		.field_pos = ID_AA64MMFR0_EL1_ECV_SHIFT,
> -		.field_width = 4,
> -		.sign = FTR_UNSIGNED,
> -		.min_field_value = ID_AA64MMFR0_EL1_ECV_CNTPOFF,
> +		ARM64_CPUID_FIELDS(ID_AA64MMFR0_EL1, ECV, CNTPOFF)
>  	},
>  #ifdef CONFIG_ARM64_PAN
>  	{
> 
> ---
> base-commit: 44c026a73be8038f03dbdeef028b642880cf1511
> change-id: 20230523-arm64-ecv-helper-c1665690b8b0
> 
> Best regards,