linux-kernel - Re: [PATCH v3] usb: common: usb-conn-gpio: Set last role to unknown before initial detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fbfc6917-d938-a055-2f58-e70a6d454ea2@quicinc.com>
Date:   Thu, 25 May 2023 14:20:37 +0530
From:   Prashanth K <quic_prashk@...cinc.com>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Matthias Brugger <matthias.bgg@...il.com>
CC:     <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] usb: common: usb-conn-gpio: Set last role to unknown
 before initial detection



On 25-05-23 02:15 pm, AngeloGioacchino Del Regno wrote:
> Il 25/05/23 10:40, Prashanth K ha scritto:
>> Currently if we bootup a device without cable connected, then
>> usb-conn-gpio won't call set_role() since last_role is same as
>> current role. This happens because during probe last_role gets
>> initialised to zero.
>>
>> To avoid this, added a new constant in enum usb_role, last_role
>> is set to USB_ROLE_UNKNOWN before performing initial detection.
>>
>> Fixes: 4602f3bff266 ("usb: common: add USB GPIO based connection 
>> detection driver")
>> Signed-off-by: Prashanth K <quic_prashk@...cinc.com>
> 
> I'm sorry to make a call for v4, but you have to mention that you're 
> touching
> the cdns3 driver in the commit description, if you want to keep the entire
> change set in one commit... otherwise you'll have to split it in two, 
> one adding
> the new entry to the enum and fixing cdns3; the other setting the last 
> role to
> unknown in usb-conn-gpio.c.
> 
> I can suggest text for keeping that in one commit, but the choice is yours;
> 
> "While at it, also handle default case for the usb_role switch
> in cdns3 to avoid build warnings."
> 
Yea that's right, will add it in next version. Thanks for the suggestion.

Regards,
Prashanth K