linux-kernel - Re: [PATCH v6 5/6] drm: lcdif: Add multiple encoders and first bridges support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOcKUNXTFr-uyEeKkos1m0VwoB76SMdkrAuT4zHC9c8D03Apcw@mail.gmail.com>
Date:   Thu, 25 May 2023 09:45:38 +0800
From:   Ying Liu <gnuiyl@...il.com>
To:     Marek Vasut <marex@...x.de>
Cc:     Liu Ying <victor.liu@....com>, dri-devel@...ts.freedesktop.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, conor+dt@...nel.org,
        alexander.stein@...tq-group.com, shawnguo@...nel.org,
        s.hauer@...gutronix.de, krzysztof.kozlowski@...aro.org,
        robh+dt@...nel.org, linux-imx@....com,
        krzysztof.kozlowski+dt@...aro.org, kernel@...gutronix.de,
        LW@...o-electronics.de
Subject: Re: [PATCH v6 5/6] drm: lcdif: Add multiple encoders and first
 bridges support

Hi Marek,

On Thu, May 11, 2023 at 12:24 AM Marek Vasut <marex@...x.de> wrote:
> On 5/10/23 11:24, Liu Ying wrote:
> > The single LCDIF embedded in i.MX93 SoC may drive multiple displays
> > simultaneously.  Look at LCDIF output port's remote port parents to
> > find all enabled first bridges.  Add an encoder for each found bridge
> > and attach the bridge to the encoder.  This is a preparation for
> > adding i.MX93 LCDIF support.
> >
> > Tested-by: Alexander Stein <alexander.stein@...tq-group.com>
> > Acked-by: Alexander Stein <alexander.stein@...tq-group.com>
> > Signed-off-by: Liu Ying <victor.liu@....com>
> > ---
> > v5->v6:
> > * Drop MAX_DISPLAYS macro. (Marek)
> > * Drop the encoder member in struct lcdif_drm_private.
> > * Drop endpoint id check.
>
> It might be nice to check (based on driver data for each IP variant) the
> encoder count, but that can be a separate patch.
>
> Reviewed-by: Marek Vasut <marex@...x.de>
>
> Thanks !
>
> btw if this doesn't get picked by someone in like a week or two, let me
> know and I'll apply this via drm-misc .

Thanks for your review.  I don't see any more comments in two weeks.
Can you please go ahead to apply this series?

Regards,
Liu Ying