[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2f7981fe-e3ad-8404-b773-1ebc05f63149@denx.de>
Date: Fri, 26 May 2023 19:09:34 +0200
From: Marek Vasut <marex@...x.de>
To: Ying Liu <gnuiyl@...il.com>
Cc: Liu Ying <victor.liu@....com>, dri-devel@...ts.freedesktop.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, conor+dt@...nel.org,
alexander.stein@...tq-group.com, shawnguo@...nel.org,
s.hauer@...gutronix.de, krzysztof.kozlowski@...aro.org,
robh+dt@...nel.org, linux-imx@....com,
krzysztof.kozlowski+dt@...aro.org, kernel@...gutronix.de,
LW@...o-electronics.de
Subject: Re: [PATCH v6 5/6] drm: lcdif: Add multiple encoders and first
bridges support
On 5/25/23 03:45, Ying Liu wrote:
> Hi Marek,
Hi,
> On Thu, May 11, 2023 at 12:24 AM Marek Vasut <marex@...x.de> wrote:
>> On 5/10/23 11:24, Liu Ying wrote:
>>> The single LCDIF embedded in i.MX93 SoC may drive multiple displays
>>> simultaneously. Look at LCDIF output port's remote port parents to
>>> find all enabled first bridges. Add an encoder for each found bridge
>>> and attach the bridge to the encoder. This is a preparation for
>>> adding i.MX93 LCDIF support.
>>>
>>> Tested-by: Alexander Stein <alexander.stein@...tq-group.com>
>>> Acked-by: Alexander Stein <alexander.stein@...tq-group.com>
>>> Signed-off-by: Liu Ying <victor.liu@....com>
>>> ---
>>> v5->v6:
>>> * Drop MAX_DISPLAYS macro. (Marek)
>>> * Drop the encoder member in struct lcdif_drm_private.
>>> * Drop endpoint id check.
>>
>> It might be nice to check (based on driver data for each IP variant) the
>> encoder count, but that can be a separate patch.
>>
>> Reviewed-by: Marek Vasut <marex@...x.de>
>>
>> Thanks !
>>
>> btw if this doesn't get picked by someone in like a week or two, let me
>> know and I'll apply this via drm-misc .
>
> Thanks for your review. I don't see any more comments in two weeks.
> Can you please go ahead to apply this series?
Done, applied to drm-misc-next , thanks !
Thanks for the reminder too .
Powered by blists - more mailing lists