linux-kernel - Re: [PATCH net-next] net: fec: remove last_bdp from fec_enet_txq_xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZG8lpJvFnZlA3w2q@corigine.com>
Date:   Thu, 25 May 2023 11:08:52 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     wei.fang@....com
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, shenwei.wang@....com, xiaoning.wang@....com,
        netdev@...r.kernel.org, linux-imx@....com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: fec: remove last_bdp from
 fec_enet_txq_xmit_frame()

On Thu, May 25, 2023 at 04:38:24PM +0800, wei.fang@....com wrote:
> From: Wei Fang <wei.fang@....com>
> 
> Actually, the last_bdp is useless in fec_enet_txq_xmit_frame(),
> so remove it.

I think it would be useful to describe why it is useless.

F.e. because it is set to bdp, which doesn't change,
so bdp can be used directly instead.

> Signed-off-by: Wei Fang <wei.fang@....com>

-- 
pw-bot: cr