linux-kernel - RE: [PATCH net-next] net: fec: remove last_bdp from fec_enet_txq_xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 25 May 2023 09:46:54 +0000
From:   Wei Fang <wei.fang@....com>
To:     Simon Horman <simon.horman@...igine.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        Shenwei Wang <shenwei.wang@....com>,
        Clark Wang <xiaoning.wang@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next] net: fec: remove last_bdp from
 fec_enet_txq_xmit_frame()

> -----Original Message-----
> From: Simon Horman <simon.horman@...igine.com>
> Sent: 2023年5月25日 17:09
> To: Wei Fang <wei.fang@....com>
> Cc: davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org;
> pabeni@...hat.com; Shenwei Wang <shenwei.wang@....com>; Clark Wang
> <xiaoning.wang@....com>; netdev@...r.kernel.org; dl-linux-imx
> <linux-imx@....com>; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH net-next] net: fec: remove last_bdp from
> fec_enet_txq_xmit_frame()
> 
> On Thu, May 25, 2023 at 04:38:24PM +0800, wei.fang@....com wrote:
> > From: Wei Fang <wei.fang@....com>
> >
> > Actually, the last_bdp is useless in fec_enet_txq_xmit_frame(), so
> > remove it.
> 
> I think it would be useful to describe why it is useless.
> 
> F.e. because it is set to bdp, which doesn't change, so bdp can be used directly
> instead.
> 
Sorry, I'll refine the commit message in the next version. Thank you!