linux-kernel - Re: [PATCH] omap_ssi_port.c: Fix error checking for debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230525125646.f4rfjb2limbtuh2c@mercury.elektranox.org>
Date:   Thu, 25 May 2023 14:56:46 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Osama Muhammad <osmtendev@...il.com>
Cc:     jinpu.wang@...os.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] omap_ssi_port.c: Fix error checking for
 debugfs_create_dir

Hi,

On Tue, May 23, 2023 at 10:24:34PM +0500, Osama Muhammad wrote:
> This patch fixes the error checking in omap_ssi_port.c in
> debugfs_create_dir. The correct way to check if an error occurred
> is 'IS_ERR' inline function.
> 
> Signed-off-by: Osama Muhammad <osmtendev@...il.com>
> ---

This masks the error code. But the proper fix is to just ignore any
errors as the help text for debugfs_create_dir() explains. Please send
a new patch removing the 'if (!dir) return -ENOMEM;'. Also the
function can be changed to be of type void afterwards.

Thanks,

-- Sebastian

>  drivers/hsi/controllers/omap_ssi_port.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hsi/controllers/omap_ssi_port.c b/drivers/hsi/controllers/omap_ssi_port.c
> index b9495b720f1b..7ad41599baa5 100644
> --- a/drivers/hsi/controllers/omap_ssi_port.c
> +++ b/drivers/hsi/controllers/omap_ssi_port.c
> @@ -157,12 +157,12 @@ static int ssi_debug_add_port(struct omap_ssi_port *omap_port,
>  	struct hsi_port *port = to_hsi_port(omap_port->dev);
>  
>  	dir = debugfs_create_dir(dev_name(omap_port->dev), dir);
> -	if (!dir)
> +	if (IS_ERR(dir))
>  		return -ENOMEM;
>  	omap_port->dir = dir;
>  	debugfs_create_file("regs", S_IRUGO, dir, port, &ssi_port_regs_fops);
>  	dir = debugfs_create_dir("sst", dir);
> -	if (!dir)
> +	if (IS_ERR(dir))
>  		return -ENOMEM;
>  	debugfs_create_file_unsafe("divisor", 0644, dir, port,
>  				   &ssi_sst_div_fops);
> -- 
> 2.34.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)