linux-kernel - Re: [PATCH 3/4] clk: qcom: camcc-sm8550: Add camera clock controller driver for SM8550

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a1a5403-8e56-9c47-02e1-78bba820581e@quicinc.com>
Date:   Thu, 25 May 2023 22:19:51 +0530
From:   Jagadeesh Kona <quic_jkona@...cinc.com>
To:     Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        "Stephen Boyd" <sboyd@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
CC:     Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Taniya Das <quic_tdas@...cinc.com>,
        "Satya Priya Kakitapalli" <quic_skakitap@...cinc.com>,
        <quic_ajipan@...cinc.com>, <quic_imrashai@...cinc.com>
Subject: Re: [PATCH 3/4] clk: qcom: camcc-sm8550: Add camera clock controller
 driver for SM8550

Hi Bryan,

Thanks for your review!

On 5/20/2023 1:56 AM, Bryan O'Donoghue wrote:
> On 19/05/2023 16:56, Jagadeesh Kona wrote:
>> +MODULE_DESCRIPTION("QTI CAM_CC SM8550 Driver");
> 
> This pattern looks odd and inconsistent in our clock drivers. We mostly 
> have CAMCC or VIDEOCC but occasionally have CAM_CC and VIDEO_CC.
> 
> I'd drop that underscore to, in addition to Konrad's comment on Ucase hex.
> 
> Other than that, LGTM.
>
Will take care of this in next series.

> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>

Thanks & Regards,
Jagadeesh