[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230526193040.2xto63ajkxsx5k5n@ripper>
Date: Fri, 26 May 2023 12:30:40 -0700
From: Bjorn Andersson <andersson@...nel.org>
To: Varadarajan Narayanan <quic_varada@...cinc.com>
Cc: agross@...nel.org, konrad.dybcio@...aro.org, amitk@...nel.org,
thara.gopinath@...il.com, rafael@...nel.org,
daniel.lezcano@...aro.org, rui.zhang@...el.com, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
Praveenkumar I <quic_ipkumar@...cinc.com>
Subject: Re: [PATCH v4 2/3] arm64: dts: qcom: ipq9574: add tsens node
On Wed, May 24, 2023 at 03:06:10PM +0530, Varadarajan Narayanan wrote:
> IPQ9574 has a tsens v2.3.1 peripheral which monitors temperatures
> around the various subsystems on the die.
>
> Co-developed-by: Praveenkumar I <quic_ipkumar@...cinc.com>
> Signed-off-by: Praveenkumar I <quic_ipkumar@...cinc.com>
> Signed-off-by: Varadarajan Narayanan <quic_varada@...cinc.com>
> ---
> [v2]:
> Add "qcom,ipq8074-tsens" as fallback compatible
> ---
> arch/arm64/boot/dts/qcom/ipq9574.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> index 0ab5556..15c9447 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> @@ -958,6 +958,15 @@
> status = "disabled";
> };
>
> + tsens: thermal-sensor@...000 {
> + compatible = "qcom,ipq9574-tsens", "qcom,ipq8074-tsens";
> + reg = <0x4a9000 0x1000>, /* TM */
Please pad addresses to 8 digits, and sort nodes by address.
Regards,
Bjorn
> + <0x4a8000 0x1000>; /* SROT */
> + interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "combined";
> + #qcom,sensors = <16>;
> + #thermal-sensor-cells = <1>;
> + };
> };
>
> timer {
> --
> 2.7.4
>
Powered by blists - more mailing lists