[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <98e4684b-725f-92f0-2920-d7bd582f60db@linaro.org>
Date: Tue, 30 May 2023 13:28:30 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Varadarajan Narayanan <quic_varada@...cinc.com>, agross@...nel.org,
andersson@...nel.org, konrad.dybcio@...aro.org, amitk@...nel.org,
thara.gopinath@...il.com, rafael@...nel.org,
daniel.lezcano@...aro.org, rui.zhang@...el.com, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Praveenkumar I <quic_ipkumar@...cinc.com>
Subject: Re: [PATCH v4 1/3] dt-bindings: thermal: tsens: Add ipq9574
compatible
On 24/05/2023 11:36, Varadarajan Narayanan wrote:
> From: Praveenkumar I <quic_ipkumar@...cinc.com>
>
> Qualcomm IPQ9574 has tsens v2.3.1 block, which is similar to IPQ8074 tsens.
>
> Signed-off-by: Praveenkumar I <quic_ipkumar@...cinc.com>
> Signed-off-by: Varadarajan Narayanan <quic_varada@...cinc.com>
> ---
> [v4]:
> Add description about IPQ9574 and remove unnecessary
> additions to the file
> [v3]:
> Fix dt_binding_check & dtbs_check errors (Used
> Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
> as reference/example)
>
> Drop 'Acked-by: Rob Herring' as suggested in review
>
> [v2]:
> Thanks to Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> for the tip to make qcom,ipq8074-tsens as fallback.
> ---
> Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> index d1ec963..1a752e0 100644
> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> @@ -16,9 +16,14 @@ description: |
> The IP versions are named v0.1, v1 and v2 in the driver, where v0.1 captures
> everything before v1 when there was no versioning information.
>
> + Since IPQ9574 is similar to IPQ8074, mapping it to IPQ8074 without
> + introducing a new compatible.
> +
> properties:
> compatible:
> oneOf:
> + - const: qcom,ipq8074-tsens
No, no need to move it to const. Was correct before.
> +
> - description: msm8960 TSENS based
> items:
> - enum:
> @@ -64,8 +69,10 @@ properties:
> - const: qcom,tsens-v2
>
> - description: v2 of TSENS with combined interrupt
> - enum:
> - - qcom,ipq8074-tsens
Again, "-" means you remove a diff hunk. `man diff` and `man patch` (or
Wikipedia, dunno).
> + items:
> + - enum:
> + - qcom,ipq9574-tsens
> + - const: qcom,ipq8074-tsens
No, do not touch existing entry.
You need new item on entire list with two compatibles:
+ items:
+ - enum:
+ - qcom,ipq9574-tsens
+ - const: qcom,ipq8074-tsens
That's it. There should be no removal hunks in your diff (so one with "-").
Best regards,
Krzysztof
Powered by blists - more mailing lists