lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZHBhvrJ7HyR6/Pgg@corigine.com>
Date:   Fri, 26 May 2023 09:37:34 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Florian Fainelli <florian.fainelli@...adcom.com>
Cc:     netdev@...r.kernel.org, Doug Berger <doug.berger@...adcom.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2] net: phy: broadcom: Register dummy IRQ
 handler

On Thu, May 25, 2023 at 10:59:15AM -0700, Florian Fainelli wrote:
> In order to have our interrupt descriptor fully setup and in particular
> the action, ensure that we register a full fledged interrupt handler.
> This also allow us to set the interrupt polarity and flow through the
> same call.
> 
> This is specifically necessary for kernel/irq/pm.c::suspend_device_irq
> to set the interrupt descriptor to the IRQD_WAKEUP_ARMED state and
> enable the interrupt for wake-up since it was still in a disabled state.
> 
> Without an interrupt descriptor we would have ran into cases where the
> wake-up interrupt is not capable of waking up the system, specifically
> if we resumed the system ACPI S5 using the Ethernet PHY. In that case
> the Ethernet PHY interrupt would be pending by the time the kernel
> booted, which it would acknowledge but then we could never use it as
> a wake-up source again.
> 
> Fixes: 8baddaa9d4ba ("net: phy: broadcom: Add support for Wake-on-LAN")
> Suggested-by: Doug Berger <doug.berger@...adcom.com>
> Debugged-by: Doug Berger <doug.berger@...adcom.com>
> Signed-off-by: Florian Fainelli <florian.fainelli@...adcom.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ