[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230526073653.GA903183@linux.intel.com>
Date: Fri, 26 May 2023 09:36:53 +0200
From: Stanislaw Gruszka <stanislaw.gruszka@...ux.intel.com>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>,
Oded Gabbay <ogabbay@...nel.org>,
dri-devel@...ts.freedesktop.org,
Jacek Lawrynowicz <jacek.lawrynowicz@...ux.intel.com>,
Andrzej Kacprowski <andrzej.kacprowski@...ux.intel.com>,
Krystian Pradzynski <krystian.pradzynski@...ux.intel.com>,
Jeffrey Hugo <quic_jhugo@...cinc.com>,
Daniel Vetter <daniel.vetter@...ll.ch>
Subject: Re: [PATCH] accel/ivpu: ivpu_ipc needs GENERIC_ALLOCATOR
On Thu, May 25, 2023 at 09:45:19PM -0700, Randy Dunlap wrote:
> Drivers that use the gen_pool*() family of functions should
> select GENERIC_ALLOCATOR to prevent build errors like these:
>
> ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free':
> include/linux/genalloc.h:172: undefined reference to `gen_pool_free_owner'
> ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_alloc_algo':
> include/linux/genalloc.h:138: undefined reference to `gen_pool_alloc_algo_owner'
> ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free':
> include/linux/genalloc.h:172: undefined reference to `gen_pool_free_owner'
> ld: drivers/accel/ivpu/ivpu_ipc.o: in function `ivpu_ipc_init':
> drivers/accel/ivpu/ivpu_ipc.c:441: undefined reference to `devm_gen_pool_create'
> ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_add_virt':
> include/linux/genalloc.h:104: undefined reference to `gen_pool_add_owner'
>
> Fixes: 5d7422cfb498 ("accel/ivpu: Add IPC driver and JSM messages")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kernel test robot <lkp@...el.com>
> Link: https://lore.kernel.org/all/202305221206.1TaugDKP-lkp@intel.com/
> Cc: Oded Gabbay <ogabbay@...nel.org>
> Cc: dri-devel@...ts.freedesktop.org
> Cc: Jacek Lawrynowicz <jacek.lawrynowicz@...ux.intel.com>
> Cc: Stanislaw Gruszka <stanislaw.gruszka@...ux.intel.com>
> Cc: Andrzej Kacprowski <andrzej.kacprowski@...ux.intel.com>
> Cc: Krystian Pradzynski <krystian.pradzynski@...ux.intel.com>
> Cc: Jeffrey Hugo <quic_jhugo@...cinc.com>
> Cc: Daniel Vetter <daniel.vetter@...ll.ch>
Acked-by: Stanislaw Gruszka <stanislaw.gruszka@...ux.intel.com>
> ---
> drivers/accel/ivpu/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -- a/drivers/accel/ivpu/Kconfig b/drivers/accel/ivpu/Kconfig
> --- a/drivers/accel/ivpu/Kconfig
> +++ b/drivers/accel/ivpu/Kconfig
> @@ -7,6 +7,7 @@ config DRM_ACCEL_IVPU
> depends on PCI && PCI_MSI
> select FW_LOADER
> select SHMEM
> + select GENERIC_ALLOCATOR
> help
> Choose this option if you have a system that has an 14th generation Intel CPU
> or newer. VPU stands for Versatile Processing Unit and it's a CPU-integrated
Powered by blists - more mailing lists