linux-kernel - Re: [PATCH] Revert "dt-bindings: bridge: samsung-dsim: Make some flags optional"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b8a3e7f0-d227-117f-443b-0f6b193e792b@linaro.org>
Date:   Fri, 26 May 2023 10:21:08 +0200
From:   Neil Armstrong <neil.armstrong@...aro.org>
To:     Conor Dooley <conor.dooley@...rochip.com>
Cc:     Inki Dae <inki.dae@...sung.com>,
        Jagan Teki <jagan@...rulasolutions.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Andrzej Hajda <andrzej.hajda@...el.com>,
        Robert Foss <rfoss@...nel.org>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Revert "dt-bindings: bridge: samsung-dsim: Make some
 flags optional"

On 26/05/2023 10:02, Conor Dooley wrote:
> On Fri, May 26, 2023 at 09:27:16AM +0200, Neil Armstrong wrote:
>> This reverts commit cfaf76d349837f695c8aa6d7077847fec4231fe5 which was applied
>> without review due to a bad tool manipulation.
> 
> Is it a dt-binding maintainer review that you are missing on that
> patch?

Exact

> 
> For this one:
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>

Thanks, I'll apply this revert now and wait until the original
bindings patch gets properly reviewed.

Thanks,
Neil

> 
> Thanks,
> Conor.
> 
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org>
>> ---
>>   .../devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml    | 9 ++++-----
>>   1 file changed, 4 insertions(+), 5 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
>> index 360fea81f4b6..9f61ebdfefa8 100644
>> --- a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
>> +++ b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
>> @@ -70,9 +70,7 @@ properties:
>>     samsung,burst-clock-frequency:
>>       $ref: /schemas/types.yaml#/definitions/uint32
>>       description:
>> -      DSIM high speed burst mode frequency when connected to devices
>> -      that support burst mode. If absent, the driver will use the pixel
>> -      clock from the attached device or bridge.
>> +      DSIM high speed burst mode frequency.
>>   
>>     samsung,esc-clock-frequency:
>>       $ref: /schemas/types.yaml#/definitions/uint32
>> @@ -82,8 +80,7 @@ properties:
>>     samsung,pll-clock-frequency:
>>       $ref: /schemas/types.yaml#/definitions/uint32
>>       description:
>> -      DSIM oscillator clock frequency. If absent, the driver will
>> -      use the clock frequency of sclk_mipi.
>> +      DSIM oscillator clock frequency.
>>   
>>     phys:
>>       maxItems: 1
>> @@ -137,7 +134,9 @@ required:
>>     - compatible
>>     - interrupts
>>     - reg
>> +  - samsung,burst-clock-frequency
>>     - samsung,esc-clock-frequency
>> +  - samsung,pll-clock-frequency
>>   
>>   allOf:
>>     - $ref: ../dsi-controller.yaml#
>>
>> ---
>> base-commit: cfaf76d349837f695c8aa6d7077847fec4231fe5
>> change-id: 20230526-revert-bad-binding-f77a3ca96419
>>
>> Best regards,
>> -- 
>> Neil Armstrong <neil.armstrong@...aro.org>
>>