linux-kernel - Re: [PATCH] auxdisplay: Switch i2c drivers back to use .probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72=qi4yXH+24zFHFatBdUHy_ekNrFoYnpZL0fSMa76kpug@mail.gmail.com>
Date:   Fri, 26 May 2023 12:39:55 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Cc:     Robin van der Gracht <robin@...tonic.nl>,
        Miguel Ojeda <ojeda@...nel.org>, linux-kernel@...r.kernel.org,
        kernel@...gutronix.de
Subject: Re: [PATCH] auxdisplay: Switch i2c drivers back to use .probe()

On Thu, May 25, 2023 at 10:58 PM Uwe Kleine-König
<u.kleine-koenig@...gutronix.de> wrote:
>
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
> convert back to (the new) .probe() to be able to eventually drop
> .probe_new() from struct i2c_driver.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Thanks for this! The conversion has taken a while given the date of
the first commit :)

The wording of the message was a bit confusing, perhaps a ";
finally/now" before "convert" would have helped, but no big deal.

If somebody is taking all the patches treewide, then:

    Acked-by: Miguel Ojeda <ojeda@...nel.org>

Otherwise, I will queue it.

Thanks!

Cheers,
Miguel