linux-kernel - Re: [PATCH] auxdisplay: Switch i2c drivers back to use .probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 May 2023 14:59:59 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc:     Miguel Ojeda <ojeda@...nel.org>,
        Robin van der Gracht <robin@...tonic.nl>,
        linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH] auxdisplay: Switch i2c drivers back to use .probe()

hello Miguel,

On Fri, May 26, 2023 at 12:39:55PM +0200, Miguel Ojeda wrote:
> On Thu, May 25, 2023 at 10:58 PM Uwe Kleine-König
> <u.kleine-koenig@...gutronix.de> wrote:
> >
> > After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> > call-back type"), all drivers being converted to .probe_new() and then
> > 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
> > convert back to (the new) .probe() to be able to eventually drop
> > .probe_new() from struct i2c_driver.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> Thanks for this! The conversion has taken a while given the date of
> the first commit :)
> 
> The wording of the message was a bit confusing, perhaps a ";
> finally/now" before "convert" would have helped, but no big deal.
> 
> If somebody is taking all the patches treewide, then:
> 
>     Acked-by: Miguel Ojeda <ojeda@...nel.org>
> 
> Otherwise, I will queue it.

The overall idea was to make the changes in a way to require no
coordination between maintainers. So adding this change to your tree
would be great.

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)