linux-kernel - Re: [PATCH] smb: delete an unnecessary statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ee9c0ab3-028f-cadf-c577-e57a139de5ce@quicinc.com>
Date:   Fri, 26 May 2023 21:06:19 +0530
From:   Mukesh Ojha <quic_mojha@...cinc.com>
To:     Dan Carpenter <dan.carpenter@...aro.org>,
        Steve French <sfrench@...ba.org>
CC:     Paulo Alcantara <pc@...guebit.com>,
        Ronnie Sahlberg <lsahlber@...hat.com>,
        Shyam Prasad N <sprasad@...rosoft.com>,
        Tom Talpey <tom@...pey.com>, <linux-cifs@...r.kernel.org>,
        <samba-technical@...ts.samba.org>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] smb: delete an unnecessary statement



On 5/26/2023 5:31 PM, Dan Carpenter wrote:
> We don't need to set the list iterators to NULL before a
> list_for_each_entry() loop because they are assigned inside the
> macro.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>


Reviewed-by: Mukesh Ojha <quic_mojha@...cinc.com>

-Mukesh

> ---
>   fs/smb/client/smb2ops.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/fs/smb/client/smb2ops.c b/fs/smb/client/smb2ops.c
> index 5065398665f1..6e3be58cfe49 100644
> --- a/fs/smb/client/smb2ops.c
> +++ b/fs/smb/client/smb2ops.c
> @@ -618,7 +618,6 @@ parse_server_interfaces(struct network_interface_info_ioctl_rsp *buf,
>   		 * Add a new one instead
>   		 */
>   		spin_lock(&ses->iface_lock);
> -		iface = niface = NULL;
>   		list_for_each_entry_safe(iface, niface, &ses->iface_list,
>   					 iface_head) {
>   			ret = iface_cmp(iface, &tmp_iface);