[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230528181237.5fc6f5d9@jic23-huawei>
Date: Sun, 28 May 2023 18:12:37 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Matti Vaittinen <mazziesaccount@...il.com>
Cc: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Daniel Scally <djrscally@...il.com>,
Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Wolfram Sang <wsa@...nel.org>,
Lars-Peter Clausen <lars@...afoo.de>,
Michael Hennerich <Michael.Hennerich@...log.com>,
Andreas Klinger <ak@...klinger.de>,
Marcin Wojtas <mw@...ihalf.com>,
Russell King <linux@...linux.org.uk>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Jonathan Neuschäfer <j.neuschaefer@....net>,
Linus Walleij <linus.walleij@...aro.org>,
Paul Cercueil <paul@...pouillou.net>,
Akhil R <akhilrajeev@...dia.com>, linux-acpi@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
linux-iio@...r.kernel.org, netdev@...r.kernel.org,
openbmc@...ts.ozlabs.org, linux-gpio@...r.kernel.org,
linux-mips@...r.kernel.org
Subject: Re: [PATCH v6 6/8] pinctrl: pistachio: relax return value check for
IRQ get
On Fri, 26 May 2023 09:38:58 +0300
Matti Vaittinen <mazziesaccount@...il.com> wrote:
> fwnode_irq_get[_byname]() were changed to not return 0 anymore.
>
> Drop check for return value 0.
>
> Signed-off-by: Matti Vaittinen <mazziesaccount@...il.com>
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
>
> ---
> Revision history:
> - No changes
>
> Please note, I took Linus' reply to v4 cover-letter as ack && added the
> tag. Please let me know if this was not Ok.
Whilst I understand your point as Linus said he'd pick the patches up,
I would have left it to Linus to Ack explicitly but added a note here
to say he basically already did.
LGTM
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
>
> The first patch of the series changes the fwnode_irq_get() so this depends
> on the first patch of the series and should not be applied alone.
> ---
> drivers/pinctrl/pinctrl-pistachio.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-pistachio.c b/drivers/pinctrl/pinctrl-pistachio.c
> index 53408344927a..8c50e0091b32 100644
> --- a/drivers/pinctrl/pinctrl-pistachio.c
> +++ b/drivers/pinctrl/pinctrl-pistachio.c
> @@ -1393,12 +1393,6 @@ static int pistachio_gpio_register(struct pistachio_pinctrl *pctl)
> dev_err(pctl->dev, "Failed to retrieve IRQ for bank %u\n", i);
> goto err;
> }
> - if (!ret) {
> - fwnode_handle_put(child);
> - dev_err(pctl->dev, "No IRQ for bank %u\n", i);
> - ret = -EINVAL;
> - goto err;
> - }
> irq = ret;
>
> bank = &pctl->gpio_banks[i];
Powered by blists - more mailing lists