linux-kernel - Re: [PATCH v6] media: mtk-vpu: Ensure alignment of 8 for DTCM buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2bae7dea-afc5-96b5-c6d1-f4724bae155c@collabora.com>
Date:   Mon, 29 May 2023 10:31:08 +0200
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Pin-yen Lin <treapking@...omium.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Hans Verkuil <hverkuil-cisco@...all.nl>
Cc:     Tiffany Lin <tiffany.lin@...iatek.com>,
        linux-mediatek@...ts.infradead.org,
        Andrew-CT Chen <andrew-ct.chen@...iatek.com>,
        Minghsiu Tsai <minghsiu.tsai@...iatek.com>,
        Houlong Wei <houlong.wei@...iatek.com>,
        Yunfei Dong <yunfei.dong@...iatek.com>,
        linux-media@...r.kernel.org, Hsin-Yi Wang <hsinyi@...omium.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Alexandre Courbot <acourbot@...omium.org>
Subject: Re: [PATCH v6] media: mtk-vpu: Ensure alignment of 8 for DTCM buffer

Il 26/05/23 08:31, Pin-yen Lin ha scritto:
> From: Alexandre Courbot <acourbot@...omium.org>
> 
> When running memcpy_toio:
> memcpy_toio(send_obj->share_buf, buf, len);
> it was found that errors appear if len is not a multiple of 8:
> 
> [58.350841] mtk-mdp 14001000.rdma: processing failed: -22
> 
> This is because in ARM64, memcpy_toio does byte-size access
> when the length is not a multiple of 8 while access to the
> vpu iomem must be 4 aligned.
> 
> This patch ensures the copy of a multiple of 8 size by calling
> round_up(len, 8) when copying.
> 
> Fixes: e6599adfad30 ("media: mtk-vpu: avoid unaligned access to DTCM buffer.")
> Signed-off-by: Alexandre Courbot <acourbot@...omium.org>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@...labora.com>
> Signed-off-by: Pin-yen Lin <treapking@...omium.org>
> Reviewed-by: Houlong Wei <houlong.wei@...iatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> 
> ---
> This is a re-send of v5 because it was marked obsolete, but this patch
> is required for MT8173 platforms.
> 

Hello,
I have solved this issue in a different way and the commit was already picked.

Please check:
ab14c99c035d ("media: platform: mtk-mdp: Fix mdp_ipi_comm structure alignment")

Regards,
Angelo