[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230529094041.s4fj6gjliivugk3r@vireshk-i7>
Date: Mon, 29 May 2023 15:10:41 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: Konrad Dybcio <konrad.dybcio@...aro.org>
Cc: Viresh Kumar <vireshk@...nel.org>, Nishanth Menon <nm@...com>,
Stephen Boyd <sboyd@...nel.org>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Marijn Suijten <marijn.suijten@...ainline.org>,
linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] opp: Provide a function for just setting bandwidth
On 29-05-23, 11:35, Konrad Dybcio wrote:
> I think I didn't state my intentions correctly..
>
> The proposed function would set *just* the bandwidth through OPP,
> so it'd be essentially equal to
>
> loop over num_paths {
> icc_get(...)
>
> icc_set(...)
>
> icc_put(...)
> }
Right, but why do you need to do it ? Why isn't this done as part of
dev_pm_opp_set_{freq|opp}() ?
> but since OPP already picked up these interconnect paths, it makes
> little sense to mess with them through raw APIs.
I am not sure if I would want to expose an API to just configure part of the
entire OPP switching mechanism. I would rather let you do that via ICC APIs,
instead of going through the OPP core. Since there is a possibility of
accidental misuse of the same here.
--
viresh
Powered by blists - more mailing lists