[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230529122017.10620-1-harini.katakam@amd.com>
Date: Mon, 29 May 2023 17:50:15 +0530
From: Harini Katakam <harini.katakam@....com>
To: <andrew@...n.ch>, <hkallweit1@...il.com>, <linux@...linux.org.uk>,
<davem@...emloft.net>, <kuba@...nel.org>, <edumazet@...gle.com>,
<pabeni@...hat.com>, <vladimir.oltean@....com>,
<wsa+renesas@...g-engineering.com>, <simon.horman@...igine.com>,
<david.epping@...singlinkelectronics.com>,
<mk+kernel@...linux.org.uk>
CC: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<harinikatakamlinux@...il.com>, <michal.simek@....com>,
<harini.katakam@....com>, <radhey.shyam.pandey@....com>
Subject: [PATCH net-next v5 0/2] Add support for VSC85xx DT RGMII delays
Provide an option to change RGMII delay value via devicetree.
v5:
- Rebase after VSC8501 series is merged, to avoid conflicts
- Rename _internal_delay to use vsc86xx, move declaration and
simplify format of pointer to above
- Acquire DT delay values in vsc85xx_update_rgmii_cntl instead of
vsc85xx_config_init to accommodate all VSC phy versions
v4:
- Remove VSC8531_02 support. Existing code will identify VSC8531_01/02
and there is no unique functionality to be added for either version.
- Correct type of rx/tx_delay to accept correct return value.
- Added Andrew's tag to patch 1
Lore link for v3:
https://lore.kernel.org/netdev/20230511120808.28646-1-harini.katakam@amd.com/
v3 changes:
- Remove patch 2/3 from v2 as custom mscc properties dont need to be
defined. rx-internal-delay-ps and tx-internal-delay-ps can be used.
- Change RGMII delay precedence as advised by Vladimir:
phy-mode rgmii rgmii-rxid/rgmii-id
--------------------------------------------------------------------------------------------
rx-internal-delay-ps absent 0.2 ns 2 ns
rx-internal-delay-ps present follow rx-internal-delay-ps follow rx-internal-delay-ps
- Split VSC8531-02 and RGMII delay config into separate patches.
- Correct vendor ID
- Update commit description and subject everywhere to say RGMII delays
instead of RGMII tuning.
v2 changes:
- Added patch to use a common vendor phy id match
- Removed dt include header patch because delays should be specied in
ps, not register values
- Updated DT binding description and commit for optional delay tuning to
be clearer on the precedence
- Updated dt property name to include vendor instead of phy device name
- Switch both VSC8531 and VSC8531-02 to use exact phy id match as they
share the same model number
- Ensure RCT
- Improve optional property read
Harini Katakam (2):
phy: mscc: Use PHY_ID_MATCH_VENDOR to minimize PHY ID table
phy: mscc: Add support for RGMII delay configuration
drivers/net/phy/mscc/mscc.h | 1 +
drivers/net/phy/mscc/mscc_main.c | 51 +++++++++++++++++++-------------
2 files changed, 31 insertions(+), 21 deletions(-)
--
2.17.1
Powered by blists - more mailing lists