[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CANiq72ntH+6nBHLpwbYbja189TX8WvOpD98=xNROPXPfmuwjtA@mail.gmail.com>
Date: Tue, 30 May 2023 16:21:54 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Qingsong Chen <changxian.cqs@...group.com>
Cc: linux-kernel@...r.kernel.org,
田洪亮 <tate.thl@...group.com>,
Boqun Feng <boqun.feng@...il.com>,
Miguel Ojeda <ojeda@...nel.org>,
Alex Gaynor <alex.gaynor@...il.com>,
Wedson Almeida Filho <wedsonaf@...il.com>,
Gary Guo <gary@...yguo.net>,
Björn Roy Baron <bjorn3_gh@...tonmail.com>,
Benno Lossin <benno.lossin@...ton.me>,
Martin Rodriguez Reboredo <yakoyoku@...il.com>,
Asahi Lina <lina@...hilina.net>,
Sven Van Asbroeck <thesven73@...il.com>,
Viktor Garske <viktor@...ar.de>, Finn Behrens <me@...enk.dev>,
rust-for-linux@...r.kernel.org
Subject: Re: [PATCH 2/2] samples: rust: add `SgTable` and `ScatterList` selftests
On Tue, May 30, 2023 at 8:54 AM Qingsong Chen
<changxian.cqs@...group.com> wrote:
>
> Add a selftest module to provide a temporary place to put "pure tests"
> for Rust funtionality and wrappers.
Thanks for the patch series! Quick note on this: the `selftest` sample
module was a temporary place we had in the `rust` branch to put some
non-doctest tests until we had a better way to run them.
Even if we wanted to keep this approach for tests like this, this part
should be in its own patch -- that way you can credit Boqun properly
and avoid adding his SoB on code he did not write (which he may not
agree with).
Cheers,
Miguel
Powered by blists - more mailing lists