linux-kernel - Re: [PATCH] fs/buffer: using __bio_add_page in submit_bh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZHVv+rPl7iL3dMqi@casper.infradead.org>
Date:   Tue, 30 May 2023 04:39:38 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     gouhao@...ontech.com
Cc:     viro@...iv.linux.org.uk, brauner@...nel.org, axboe@...nel.dk,
        linux-fsdevel@...r.kernel.org, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/buffer: using __bio_add_page in submit_bh_wbc()

On Tue, May 30, 2023 at 11:32:39AM +0800, gouhao@...ontech.com wrote:
> From: Gou Hao <gouhao@...ontech.com>
> 
> In submit_bh_wbc(), bio is newly allocated, so it
> does not need any merging logic.
> 
> And using bio_add_page here will execute 'bio_flagged(
> bio, BIO_CLONED)' and 'bio_full' twice, which is unnecessary.

https://lore.kernel.org/linux-fsdevel/20230502101934.24901-5-johannes.thumshirn@wdc.com/

You could send some Reviewed-by: tags to that patch series.