linux-kernel - Re: [PATCH 3/4] arm64: dts: qcom: sm8550: enable PMIC RTC on MTP & QRD boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d76f1e0d-8747-91f7-63f1-9ad85dafef9c@linaro.org>
Date:   Tue, 30 May 2023 09:29:43 +0200
From:   Neil Armstrong <neil.armstrong@...aro.org>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
Cc:     linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: qcom: sm8550: enable PMIC RTC on MTP &
 QRD boards

On 26/05/2023 21:51, Konrad Dybcio wrote:
> 
> 
> On 25.05.2023 17:47, Neil Armstrong wrote:
>> The PMK8550 RTC is functional on the SM8550 MTP & QRD boards,
>> let's enable them.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org>
>> ---
> WDYM "functional"? Is there a reason it shouldn't be enabled for
> everyone?

There's none, I'll enable it in the PMIC dtsi instead.

Neil

> 
> Konrad
>>   arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 4 ++++
>>   arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 4 ++++
>>   2 files changed, 8 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
>> index e2b9bb6b1e27..6bf111e655f7 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
>> @@ -496,6 +496,10 @@ &pm8550b_eusb2_repeater {
>>   	vdd3-supply = <&vreg_l5b_3p1>;
>>   };
>>   
>> +&pmk8550_rtc {
>> +	status = "okay";
>> +};
>> +
>>   &qupv3_id_0 {
>>   	status = "okay";
>>   };
>> diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
>> index 4a8177f99523..b08a8201ad23 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
>> @@ -482,6 +482,10 @@ &pm8550b_eusb2_repeater {
>>   	vdd3-supply = <&vreg_l5b_3p1>;
>>   };
>>   
>> +&pmk8550_rtc {
>> +	status = "okay";
>> +};
>> +
>>   &qupv3_id_0 {
>>   	status = "okay";
>>   };
>>